Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorting and ordering on blue and yellow frets #406

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

NeomattGZ
Copy link
Contributor

Small improvement on the current song navigation:

  • Red button now goes back to the top of the list if there is no search filter active (allows to get back to the top and select "Random" or "Recommended"
  • Yellow button now changes the sort order between song name (default), artist name, and source name.
  • Blue button filters on artist if no filter is set, and a second press filters on source instead.

Could be improved:

  • Text for navigation menu does not change (I would like to switch it to "Select Source", or "Back to Top")
  • Orange button for selecting next section works for song name and artist name, but is broken on source name (it tries to get to the bottom of the list every time, it could be due to the fact that some sources are empty)

@EliteAsian123 EliteAsian123 merged commit 04e4d16 into YARC-Official:dev Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants