Fix infinite loop generating beatlines in 1/x time signatures #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where charts finish with in a 1/x time signature (where x > 4) the beat generation code falls into an infinite loop trying to finish the song on a measure. This was impossible though as 1/x time signatures are forced to only generate the first measure as a measure line, while the rest are standard strong/weak beats.
This caused an infinite loop and generated beats until memory ran out causing the game to hang forever.
Thanks to JasonParadise for finding this bug on stream and sending me the chart to diagnose the problem.