Headers are added for the different sections, merged results, filter for songs without certain instruments #460
Conversation
+ Headers are only shown if the song list is greater than 30 songs (arbritrary number)
+ TODO: Tweak constant MIN_SONGS_FOR_SECTION_HEADERS
* Added filters to search for songs without a specific instrument
+ instrument:-guitar
+ instrument:-bass
+ instrument:-drums
+ instrument:-keys
+ instrument:-vocals
+ instrument:-band
* The search results are merged
+ source:rb1dlc;source:rb2dlc
* Fixed bug that displayed the following filter incorrectly if the back button was pressed
* SongSelection.cs class refactored
+ SongSearching.cs created
|
Filters for songs without a specific instrument
|
|
Merged results |
|
Section headers |
|
Thats awesome! Can we also add how many songs under each header? Another thing that I think we can add, that I've added on the project figma is subheaders for Artists, so we can have subheadead for each album |
|
Hello, the current implementation of the headers is a button without associated functionality ButtonViewType that is inserted in the appropriate place. Apparently the CategoryViewType class already has a section for counting, but we would have to modify the way in which the songs are added, to add them by section step by step and not globally. Regarding the subheadings we would have to create a new class that extends ViewType that contains a list of SongViewType, but I believe that it is possible. |
Assets/Script/Song/SongSearching.cs
Outdated
| } | ||
| } | ||
|
|
||
| private readonly static List<Tuple<string, string>> troublesomeCharacters = new List<Tuple<string, string>>{ |
There was a problem hiding this comment.
List<Tuple<string, string>> can be simplified to List<(string, string)>, or better yet, List<(string from, string to)>.
* * Headers are added for the different sections
+ Headers are only shown if the song list is greater than 30 songs (arbritrary number)
+ TODO: Tweak constant MIN_SONGS_FOR_SECTION_HEADERS
* Added filters to search for songs without a specific instrument
+ instrument:-guitar
+ instrument:-bass
+ instrument:-drums
+ instrument:-keys
+ instrument:-vocals
+ instrument:-band
* The search results are merged
+ source:rb1dlc;source:rb2dlc
* Fixed bug that displayed the following filter incorrectly if the back button was pressed
* SongSelection.cs class refactored
+ SongSearching.cs created
* * Changes made as a result of the discussion #460
* * Added sorting by song duration.
* The following sections are configured for sorting by duration:
-
00:00 - 02:00
02:00 - 05:00
05:00 - 10:00
10:00 - 15:00
15:00 - 20:00
20:00+
* The cursor moves one position when a section header is pressed.
* The SongSelection.cs class is slightly refactored
* * Changes made as a result of the discussion #471
Headers are only shown if the song list is greater than 30 songs (arbritrary number)
Added filters to search for songs without a specific instrument
The search results are merged
Fixed bug that displayed the following filter incorrectly if the back button was pressed
SongSelection.cs class refactored