Various Microphone/Vocals fixes #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
ExecutionEngineException: String conversion error: Illegal byte sequence encounted in the input.exception. By default on Windows, BASS will retrieve device names in ANSI, even if they are Unicode names (other platforms always use Unicode). BASS has a config option to use Unicode on Windows so I enabled that.Changed the device list to use a whitelist of types instead of including all non-loopback devices. The list may not be completely exhaustive yet but it excludes most devices which aren't recording devices.
Fixed the
SampleFormaterror when trying to initialise a microphone (particularly on Linux). I believe this is caused by Linux/devices on Linux not supporting floating point sample recording. Instead it now uses standard 16-bit samples and does the floating point conversion manually for pitch detection logic