Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce log pollution and increase retention period #791

Merged

Conversation

richardzilincikPantheon
Copy link
Contributor

Removed the most noisy and least useful log messages,
filter out healcheck pings from logging, change log
rotation to weekly with retention for a year.

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #791 (cfabf47) into develop (62fb5ed) will decrease coverage by 0.05%.
The diff coverage is 28.57%.

❗ Current head cfabf47 differs from pull request most recent head f3dd951. Consider uploading reports for the commit f3dd951 to get more accurate results

@@             Coverage Diff             @@
##           develop     #791      +/-   ##
===========================================
- Coverage    77.73%   77.69%   -0.05%     
===========================================
  Files          110      110              
  Lines        11394    11378      -16     
===========================================
- Hits          8857     8840      -17     
- Misses        2537     2538       +1     
Impacted Files Coverage Δ
api/views/health_check.py 21.48% <ø> (+0.26%) ⬆️
api/views/yang_search/yang_search.py 14.28% <0.00%> (+0.02%) ⬆️
parseAndPopulate/resolvers/generated_from.py 100.00% <ø> (ø)
parseAndPopulate/resolvers/module_type.py 89.47% <ø> (-0.53%) ⬇️
parseAndPopulate/resolvers/organization.py 84.37% <ø> (-0.48%) ⬇️
parseAndPopulate/resolvers/semantic_version.py 100.00% <ø> (ø)
parseAndPopulate/resolvers/submodule.py 100.00% <ø> (ø)
parseAndPopulate/resolvers/yang_version.py 100.00% <ø> (ø)
parseAndPopulate/resolvers/prefix.py 92.68% <50.00%> (-0.35%) ⬇️
parseAndPopulate/resolvers/namespace.py 92.68% <75.00%> (-0.35%) ⬇️
... and 2 more

... and 1 file with indirect coverage changes

@SlavomirMazurPantheon SlavomirMazurPantheon merged commit 7922bcf into YangCatalog:develop Jul 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review logs and potential for a longer retention period
3 participants