5.10.1 Release

Signed-off-by: SlavomirMazurPantheon <slavomir.mazur@pantheon.tech>
YangCatalog · Mar 20, 2023 · 62b4877 · 62b4877
1 parent e4ad249
commit 62b4877
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 18 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 ## Frontend Release Notes
 
+* ##### v5.10.1 - 2023-03-20
+
+  * Bugfix: compilation results table displaying [#30](https://github.com/YangCatalog/frontend/issues/30)
+
 * ##### v5.10.0 - 2023-03-07
 
   * Source code improved by npm lint

diff --git a/admin-ui/CHANGELOG.md b/admin-ui/CHANGELOG.md
@@ -1,7 +1,5 @@
 ## Admin UI Release Notes
 
-* ##### vm.m.p - 2022-MM-DD
-
 * ##### v5.5.0 - 2022-08-16
 
   * No changes - released with other [deployment submodules](https://github.com/YangCatalog/deployment)

diff --git a/yangcatalog-ui/CHANGELOG.md b/yangcatalog-ui/CHANGELOG.md
@@ -1,7 +1,5 @@
 ## YANG Catalog UI Release Notes
 
-* ##### vm.m.p - 2022-MM-DD
-
 * ##### v5.5.0 - 2022-08-16
 
   * Check if regex is valid if using regex search [#97](https://github.com/YangCatalog/yangcatalog-ui/issues/97)

diff --git a/yangcatalog-ui/package-lock.json b/yangcatalog-ui/package-lock.json
diff --git a/yangcatalog-ui/src/app/app.component.ts b/yangcatalog-ui/src/app/app.component.ts
@@ -11,7 +11,6 @@ import { AppService } from './app.service';
   styleUrls: ['./app.component.css']
 })
 export class AppComponent implements OnInit {
-  private toastr: ToastrService;
 
   defaultTitle = 'YANG Catalog';
 
@@ -20,22 +19,21 @@ export class AppComponent implements OnInit {
     private title: Title,
     private tracker: MatomoTracker,
     private dataService: AppService,
-    private toastrService: ToastrService) {
-      this.toastr = toastrService;
-    }
+    private toastrService: ToastrService) { }
 
   public showNotification() {
     this.dataService.getNotificationJson().subscribe(
-      notification_json => {
-        if ('type' in notification_json && 'message' in notification_json) {
-          if (notification_json['type'] == 'info') {
-            this.toastr.info(notification_json['message'], '', {disableTimeOut: true, closeButton: true, positionClass: 'toast-bottom-right'});
-          } else if (notification_json['type'] == 'warning') {
-            this.toastr.warning(notification_json['message'], '', {disableTimeOut: true, closeButton: true, positionClass: 'toast-bottom-right'});
+      notificationJson => {
+        if ('type' in notificationJson && 'message' in notificationJson) {
+          const override = { disableTimeOut: true, closeButton: true, positionClass: 'toast-bottom-right' };
+          if (notificationJson['type'] === 'info') {
+            this.toastrService.info(notificationJson['message'], '', override);
+          } else if (notificationJson['type'] === 'warning') {
+            this.toastrService.warning(notificationJson['message'], '', override);
           }
         }
       },
-      error => {}
+      error => { }
     );
   }
 

diff --git a/yangcatalog-ui/src/app/features/private/private.service.ts b/yangcatalog-ui/src/app/features/private/private.service.ts
@@ -71,9 +71,9 @@ export class PrivateService extends DataService {
 
   private transformObjDataToRows(objData: any) {
     const result = Object.keys(objData).map(key => {
-      var keyData = Object.assign([], objData[key]['compilation_metadata']);
+      const keyData = Object.assign([], objData[key]['compilation_metadata']);
       ['pyang_lint', 'pyang', 'confdrc', 'yumadump', 'yanglint'].forEach(compRes => {
-        keyData.push(objData[key]['compilation_results'][compRes])        
+        keyData.push(objData[key]['compilation_results'][compRes]);
       });
       keyData.unshift(key);
       return keyData;