Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Added support for TYPO3 13, dropped support for 10 and PHP7 #579

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

RinyVT
Copy link
Collaborator

@RinyVT RinyVT commented Sep 17, 2024

Summary

This PR can be summarized in the following changelog entry:

  • Added support for TYPO3 13
  • Removed support for TYPO3 10 and PHP 7

Test instructions

This PR can be tested by following these steps:

  • Clone this branch
  • Run ddev start
  • Execute ddev install-all to setup the v11, v12 and v13 installations
  • Test both the frontend and backend

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #571

@saitho
Copy link

saitho commented Sep 19, 2024

Great to see preparations for TYPO3 v13 have started. :)

As of v13.3.0 TCA fields from ctrl are automatically configured.
The following now causes warnings and errors. I think it's fine to remove those.

// Configuration/TCA/tx_yoastseo_related_focuskeyword.php
        'sys_language_uid' => $GLOBALS['TCA']['tt_content']['columns']['sys_language_uid'],
        'l10n_parent' => array_replace_recursive($GLOBALS['TCA']['tt_content']['columns']['l18n_parent'], [
            'config' => [
                'foreign_table' => 'tx_yoastseo_related_focuskeyword',
                'foreign_table_where' => 'AND tx_yoastseo_related_focuskeyword.pid=###CURRENT_PID### AND tx_yoastseo_related_focuskeyword.sys_language_uid IN (-1,0)',
            ]
        ]),
        'l10n_source' => $GLOBALS['TCA']['tt_content']['columns']['l10n_source'],
        'l10n_diffsource' => $GLOBALS['TCA']['tt_content']['columns']['l18n_diffsource'],
        'hidden' => $GLOBALS['TCA']['tt_content']['columns']['hidden'],

Riny van Tiggelen and others added 3 commits September 25, 2024 19:38
… prevent some multidimensional array shapes, introduced BackendUserTrait and LanguageServiceTrait
…les, added condition for tx_yoastseo_related_focuskeyword to not include auto generated columns in 13
…-testing

[FEATURE] Implemented PHPStan level 8, introduced some DTO classes to prevent some multidimensional array shapes, introduced BackendUserTrait and LanguageServiceTrait
@RinyVT
Copy link
Collaborator Author

RinyVT commented Sep 26, 2024

@saitho Thanks for letting me know! Code worked in 13.2 but 13.3 had some more surprises so I've done some fixes.
I could net remove the TCA columns because we also support v11 and v12, but I made sure to have a version check around these columns to only add when necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v13 compatibility?
2 participants