chore: Make graph visible in GUI, and show a proper error message #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -339,9 +339,14 @@ private function getVisualization($workflow, $format): string | |||
| throw new \InvalidArgumentException($this->trans('workflow_cmd_not_found', ['dot'])); | |||
| } | |||
|
|
|||
| $workflowRepository = $this->repository->find($workflow); | |||
|
|
|||
| if ($workflowRepository && !$workflowRepository['enabled']) { | |||
There was a problem hiding this comment.
Possibly rewrite as !($workflowRepository['enabled'] ?? false)
There was a problem hiding this comment.
I did split it up in two messengers, so it become more clear for enduser
| @@ -114,3 +114,4 @@ workflow_gui: 'Workflow GUI' | |||
| workflow_problem_creating_workflow_invalid_characters: 'Please use only these characters: "a-z", "A-Z" and "_"' | |||
| workflow_gui_workflow_with_name_already_exists: 'Workflow with bane already exists' | |||
| workflow_gui_clone: 'Clone' | |||
| workflow_gui_enable_message: 'Please enable and save the workflow, before you can see the graph' | |||
There was a problem hiding this comment.
This sentence is structurally incorrect. Suggestion:
Please enable and save the workflow to display graph visualization.
or something similar.
There was a problem hiding this comment.
Ah my bad English again, thank you
There was a problem hiding this comment.
I don't see an update yet.
There was a problem hiding this comment.
@kjkooistra-youwe should be oke now
jorisros
force-pushed
the
fix/65
branch
2 times, most recently
from
191e1d9
to
50a2883
Compare
jorisros
force-pushed
the
fix/65
branch
3 times, most recently
from
f6fa6b9
to
b5ca662
Compare
kjkooistra-youwe
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #65