-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#87 #65 #68 recursive addChild support #108
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed examples index.twig and layout.twig support Twitter bootstrap 3
update unit test according to to new 1.2 version
Fixed examples/layout/layout.twig
Warning file_get_contents if file does not exist
updated to prc2
Added missing $loader property
jquery.min.js needs to be loaded before bootstrap.min.js
Update layout.twig
basePath added in layout.twig
Update MapLoader.php
…hrowing deprecation notices managers that don't have the SL injected cause panic with the latest zend-servicemanager release. See \Zend\Mvc\Service\ServiceManagerConfig ``` // For service locator aware plugin managers that do not have // the service locator already injected, inject it, but emit a // deprecation notice. if ($instance instanceof ServiceLocatorAwareInterface && $instance instanceof AbstractPluginManager && ! $instance->getServiceLocator() ) { trigger_error(sprintf( 'ServiceLocatorAwareInterface is deprecated and will be removed in version 3.0, along ' . 'with the ServiceLocatorAwareInitializer. Please update your %s plugin manager factory ' . 'to inject the parent service locator via the constructor.', get_class($instance) ), E_USER_DEPRECATED); $instance->setServiceLocator($container); } ```
Inject the service manager here to prevent the latest zend-mvc from throwing deprecation notices
@spiffyjr could you look at this, please? |
…g into feature/addchild-support
Updated in #118. |
kokspflanze
added a commit
to kokspflanze/ZfcTwig
that referenced
this pull request
May 26, 2017
ZF-Commons#87 ZF-Commons#65 ZF-Commons#68 ZF-Commons#108 recursive addChild support
kokspflanze
pushed a commit
to kokspflanze/ZfcTwig
that referenced
this pull request
May 30, 2017
…dChild support (cherry picked from commit eaf04e7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow ZfcTwig to render children views.