Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Optimise dependencies by adding TFM #230

Closed
thompson-tomo opened this issue Apr 13, 2024 · 10 comments · Fixed by #231 or #233
Closed

[FEATURE] Optimise dependencies by adding TFM #230

thompson-tomo opened this issue Apr 13, 2024 · 10 comments · Fixed by #231 or #233
Assignees
@jodydonetti
Labels
enhancement New feature or request
Milestone
v1.3.0

Comments

@thompson-tomo
Copy link
Contributor

thompson-tomo commented Apr 13, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

I want to minimise dependencies in my project by utilising framework dependencies wherever possible

Describe the solution you'd like

I want the package to not have an explicit dependency on System.Text.Json as it can be provided by the framework. At the same time other dependencies can be optimised when an additional TFM is added.

Describe alternatives you've considered

Accept the additional dependency

Additional context

No response
@jodydonetti
Copy link
Collaborator

Hi @thompson-tomo , sorry I don't understand what you are asking.

Which package are you talking about? The main FusionCache package does not have a dependency on System.Text.Json, and the package that act as an adapter for that serializer must have a dependency on it, otherwise it would not work.

Can you be clearer please?

thompson-tomo added a commit to thompson-tomo/FusionCache that referenced this issue Apr 13, 2024
@thompson-tomo
ZiggyCreatures#230 add in TFM's so dependencies can be optimised
c4333d6
@thompson-tomo thompson-tomo mentioned this issue Apr 13, 2024
Merged
@thompson-tomo
Copy link
Contributor Author

@jodydonetti to make it clearer i have simply submitted a PR for the changes #231

@jodydonetti
Copy link
Collaborator

Thanks @thompson-tomo , will look into it and let you know.

jodydonetti added a commit that referenced this issue Apr 21, 2024
@thompson-tomo @jodydonetti
#230 add in TFM's so dependencies can be optimised (#231)
85d599b 
* #230 add in TFM's so dependencies can be optimised
* Better incoherent fail-safe max duration logic
* Even better incoherent fail-safe max duration handling logic (less allocation in happy path)

---------

Co-authored-by: Jody Donetti <indastria@gmail.com>
@jodydonetti jodydonetti added this to the v1.1.0 milestone Apr 21, 2024
@jodydonetti jodydonetti added the enhancement New feature or request label Apr 21, 2024
@jodydonetti jodydonetti self-assigned this Apr 21, 2024
@jodydonetti jodydonetti reopened this Apr 21, 2024
@jodydonetti
Copy link
Collaborator

God damn it if it generates a ton of warnings now 😅

image

thompson-tomo added a commit to thompson-tomo/FusionCache that referenced this issue Apr 21, 2024
@thompson-tomo
ZiggyCreatures#230 Add in suppression of TFM Warnings
cd792b1
@thompson-tomo thompson-tomo mentioned this issue Apr 21, 2024
Merged
@thompson-tomo
Copy link
Contributor Author

To make it easier i have just suppressed the build warnings via #233

@akoken
Copy link

akoken commented Apr 22, 2024

Why .NET Core 3.1 @thompson-tomo? It's out of support and full of vulnerabilities. No need to mention API changes that could be problematic. I think you shouldn't support it @jodydonetti?

@thompson-tomo
Copy link
Contributor Author

I am aware of net core 3.1 is out of support but some users still utilise it & that is the earliest framework which can provide the necessary library as part of the framework. If a user is developing for net 6 then they will get v6 of STJ.

jodydonetti added a commit that referenced this issue Apr 23, 2024
@jodydonetti
Revert "#230 add in TFM's so dependencies can be optimised (#231)"
3be88de 
This reverts commit 85d599b.
@jodydonetti jodydonetti removed this from the v1.1.0 milestone Apr 23, 2024
@jodydonetti
Copy link
Collaborator

Hi all, I think I need a little bit more time to get to the bottom of this, consider all the angles and the best approach all around.

I'll release the next version and then I'll come back to this.

Will update.

@thompson-tomo
Copy link
Contributor Author

Note from my side I have no problem bumping it net 6 or potentially adding it as an additional TFM.

thompson-tomo added a commit to thompson-tomo/FusionCache that referenced this issue May 8, 2024
@thompson-tomo
ZiggyCreatures#230 Add in suppression of TFM Warnings
a344c80
thompson-tomo added a commit to thompson-tomo/FusionCache that referenced this issue Jun 19, 2024
@thompson-tomo
ZiggyCreatures#230 Add in suppression of TFM Warnings
b5501a8
thompson-tomo added a commit to thompson-tomo/FusionCache that referenced this issue Jul 10, 2024
@thompson-tomo
ZiggyCreatures#230 Add in suppression of TFM Warnings
ac182d6
@jodydonetti jodydonetti added this to the v1.3.0 milestone Jul 21, 2024
jodydonetti added a commit that referenced this issue Jul 22, 2024
@thompson-tomo @jodydonetti
#230 Add in suppression of TFM Warnings (#233)
9050c5f 
Co-authored-by: Jody Donetti <indastria@gmail.com>
@jodydonetti
Copy link
Collaborator

Hi all, v1.3.0 is out 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodydonetti jodydonetti

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.3.0
3 participants
@jodydonetti @akoken @thompson-tomo