Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FusionCache.CompleteBackgroundFactory => Using "GetAwaiter().GetResult()" instead of ".Result" #258

Merged
merged 10 commits into from
Aug 24, 2024
Merged

FusionCache.CompleteBackgroundFactory => Using "GetAwaiter().GetResult()" instead of ".Result" #258

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
baeccb1
chore: FusionCache.CompleteBackgroundFactory => Using "GetAwaiter().G…
henriqueholtz Jun 10, 2024
9418c07
perf: Using async/await instead of "GetAwaiter().GetResult()"
henriqueholtz Jun 15, 2024
a414235
Merge branch 'main' into main
jodydonetti Jul 21, 2024
c2ceff5
Merge branch 'main' into main
jodydonetti Aug 11, 2024
416320f
Revert "perf: Using async/await instead of "GetAwaiter().GetResult()""
henriqueholtz Aug 17, 2024
b74819e
Merge branch 'main' into main
jodydonetti Aug 18, 2024
4c4547b
Merge branch 'main' into main
jodydonetti Aug 18, 2024
9fca327
Merge branch 'main' into main
jodydonetti Aug 18, 2024
481353f
Merge branch 'main' into main
jodydonetti Aug 18, 2024
a130571
Merge branch 'main' into main
jodydonetti Aug 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ZiggyCreatures.FusionCache/FusionCache.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ private void CompleteBackgroundFactory<TValue>(string operationId, string key, F
options.ReThrowBackplaneExceptions = false;

// ADAPTIVE CACHING UPDATE
var lateEntry = FusionCacheMemoryEntry<TValue>.CreateFromOptions(antecedent.Result, options, false, ctx.LastModified, ctx.ETag, null);
var lateEntry = FusionCacheMemoryEntry<TValue>.CreateFromOptions(antecedent.GetAwaiter().GetResult(), options, false, ctx.LastModified, ctx.ETag, null);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst anything is better than .Result, GetAwaiter().GetResult() is still making things synchronous.

Could it not just be awaited?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I haven't noticed that! Done.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst anything is better than .Result, GetAwaiter().GetResult() is still making things synchronous.

Could it not just be awaited?

Why? In this case we know for sure the task is already finished, why going through an extra async state machine & friends?


var mca = GetCurrentMemoryAccessor(options);
if (mca is not null)
Expand Down