Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing non-existent credentials should return null user #220

Merged
merged 2 commits into from
Feb 18, 2014

Conversation

AfzalivE
Copy link
Contributor

In getUserByIdentity, passing some credentials that don't exist like "token" actually returned a valid user when it shouldn't.

This commit fixes this behaviour.

Also reverted the previous commit which tried to fix #215 , that behaviour was also caused by this problem and seems to be fixed now.

@vgoodvin
Copy link

+1
When I pass wrong credentials to ConfideEloquentRepository::getUserByIdentity() it returns first user from DB.
Example credentials:

array(
    'email'    => null,
    'username' => null,
);

andrew13 added a commit that referenced this pull request Feb 18, 2014
Passing non-existent credentials should return null user. Thanks @AfzalivE
@andrew13 andrew13 merged commit 17ce63e into Zizaco:master Feb 18, 2014
andrew13 added a commit that referenced this pull request Mar 12, 2014
This prevents the breaking change that was implemented with #220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security: logAttempt succeeds if the password is of the first user in the users table
3 participants