Inventory analysis style #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZoeBijl
added a commit
that referenced
this pull request
Jun 9, 2024
* chore: add documentation links * fix: properly align currency in the aircraft profit dashboard * feat: add currency format helper * chore: load helpers in /action/ pages * fix(#12): change indicator color based on positive/negative values * fix: check for value in fltmng_getAircraftId function * fix(#11): properly format large numbers in flightInfo * fix(#14): add table width css * fix(#13): add some improved colours for dark mode * fix(#10): right align flight info currency columns * chore: cleanup the manifest content_scripts * fix: filter out NaN dates for “Schedule extract 'days ago'” * fix(#16): check date type for route management data * fix: prevent NaN dates * fix: filter NaN dates in getRouteAnalysisImportantDates * feat: move getAirlineCode and getServerName to helper.js * chore: change arrow function to method * feat: move formatDate to helpers.js as formatDateString fix: check if date is provided, else return * feat: move formatWeekDate to helpers.js as formatDateStringWeek * feat: move getDateDiff to helpers.js * chore: fix typo and add credits for myself * chore: bump version number * style: convert line endings to LF * chore: inventory analysis js file style (#24) * fix: only push dates if they’re integers * style: format according to .editorconfig * feat: renovate inventory analysis (#25) Fixes: - data comparison resulting in invalid results - no new flight pair data being written - Several components have been refactored and/or ported to vanilla JavaScript: Features: - settings are now loaded on page load - getServer() is now loaded from AES (helpers.js) - validation of the inventory settings is now in its own file / its own component (instead of an object) UI clean-up: - columns with numbers are right aligned - historical data now starts with newest data on the left - table cells no longer wrap, giving a cleaner more comprehensible look Commits: * feat: move cleanInteger to helpers.js * refactor: getFlights * split out into multiple functions * port to vanilla * add jsdoc * refactor: getPriceDetails * port to vanilla * add jsdoc * split into multiple functions * refactor: inventory initialisation * refactor: displayInventory * displayInventory now uses await to get local storage * feat: fix historic data table styling / reverse order * fix: get settings on page load * refactor: remove getServer() * refactor: use booleans instead of numbers * refactor: pull inventory setting validation into its own class * The “content_inventory” file is quite long as it is. Pulling this validation out into its own file makes it easier to read. * refactor: use early return when errors occur * chore: add pricingDataObjectExample * fix: correctly show price analysis * fix(#26): replace getDate() with AES.getServerDate() (#27) Removes all the duplicate getDate() functions with one centralised getServerDate() helper function. * fix: remove redundant helper functions (#29) * fix(#28): remove all duplicates of cleanInteger() * fix(#28): remove duplicates of getDateDiff * fix(#28): remove duplicates of formatDate formatDate has been replaced by AES.formatDateString * fix: simplify cleanInteger * fix: correct date extraction Apparently the footer date element is not consistently styled across all pages. This corrects for that. * style: apply .editorconfig to content_dashboard * feat: add AES menu (#32) * feat: add AES menu Adds a menu item to the main game menu. Provides easy access to the forum topic and reporting bugs. * fix: consistently align icons in menu * feat: add support for menu dividers and headers * feat: add a few menu items * fix: correctly escape url * feat: add support for modal toggle menuitems * feat(#33): add about screen (#34) * feat(#33): add about window * feat(#33): add logo to about screen * feat(#33): improve dialog styling * feat(#33): simplify code / improve close button * fix: correct heading colour in about screen
ZoeBijl
added a commit
that referenced
this pull request
Jun 11, 2024
* chore: add documentation links * fix: properly align currency in the aircraft profit dashboard * feat: add currency format helper * chore: load helpers in /action/ pages * fix(#12): change indicator color based on positive/negative values * fix: check for value in fltmng_getAircraftId function * fix(#11): properly format large numbers in flightInfo * fix(#14): add table width css * fix(#13): add some improved colours for dark mode * fix(#10): right align flight info currency columns * chore: cleanup the manifest content_scripts * fix: filter out NaN dates for “Schedule extract 'days ago'” * fix(#16): check date type for route management data * fix: prevent NaN dates * fix: filter NaN dates in getRouteAnalysisImportantDates * feat: move getAirlineCode and getServerName to helper.js * chore: change arrow function to method * feat: move formatDate to helpers.js as formatDateString fix: check if date is provided, else return * feat: move formatWeekDate to helpers.js as formatDateStringWeek * feat: move getDateDiff to helpers.js * chore: fix typo and add credits for myself * chore: bump version number * style: convert line endings to LF * chore: inventory analysis js file style (#24) * fix: only push dates if they’re integers * style: format according to .editorconfig * feat: renovate inventory analysis (#25) Fixes: - data comparison resulting in invalid results - no new flight pair data being written - Several components have been refactored and/or ported to vanilla JavaScript: Features: - settings are now loaded on page load - getServer() is now loaded from AES (helpers.js) - validation of the inventory settings is now in its own file / its own component (instead of an object) UI clean-up: - columns with numbers are right aligned - historical data now starts with newest data on the left - table cells no longer wrap, giving a cleaner more comprehensible look Commits: * feat: move cleanInteger to helpers.js * refactor: getFlights * split out into multiple functions * port to vanilla * add jsdoc * refactor: getPriceDetails * port to vanilla * add jsdoc * split into multiple functions * refactor: inventory initialisation * refactor: displayInventory * displayInventory now uses await to get local storage * feat: fix historic data table styling / reverse order * fix: get settings on page load * refactor: remove getServer() * refactor: use booleans instead of numbers * refactor: pull inventory setting validation into its own class * The “content_inventory” file is quite long as it is. Pulling this validation out into its own file makes it easier to read. * refactor: use early return when errors occur * chore: add pricingDataObjectExample * fix: correctly show price analysis * fix(#26): replace getDate() with AES.getServerDate() (#27) Removes all the duplicate getDate() functions with one centralised getServerDate() helper function. * fix: remove redundant helper functions (#29) * fix(#28): remove all duplicates of cleanInteger() * fix(#28): remove duplicates of getDateDiff * fix(#28): remove duplicates of formatDate formatDate has been replaced by AES.formatDateString * fix: simplify cleanInteger * fix: correct date extraction Apparently the footer date element is not consistently styled across all pages. This corrects for that. * style: apply .editorconfig to content_dashboard * feat: add AES menu (#32) * feat: add AES menu Adds a menu item to the main game menu. Provides easy access to the forum topic and reporting bugs. * fix: consistently align icons in menu * feat: add support for menu dividers and headers * feat: add a few menu items * fix: correctly escape url * feat: add support for modal toggle menuitems * feat(#33): add about screen (#34) * feat(#33): add about window * feat(#33): add logo to about screen * feat(#33): improve dialog styling * feat(#33): simplify code / improve close button * fix: correct heading colour in about screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix white space