fix: Remove impossible cases. Reasoning added to notion notes

test-suites/atoken-edge.spec.ts

@@ -18,10 +18,6 @@ makeSuite('Atoken-logic: edge cases', (testEnv: TestEnv) => {
     expect(await aDai.allowance(users[0].address, users[1].address)).to.be.eq(MAX_UINT_AMOUNT);
   });
 
-  it('approve() owner == address(0)', async () => {
-    expect(false, 'IMPOSSIBLE').to.be.eq(true);
-  });
-
   it('approve() spender == address(0)', async () => {
     const { users, aDai } = testEnv;
     await expect(

test-suites/pool-edge.spec.ts

@@ -143,17 +143,6 @@ makeSuite('Pool - edge cases', (testEnv: TestEnv) => {
     ).to.be.revertedWith(RL_RESERVE_ALREADY_INITIALIZED);
   });
 
-  it('GenericLogic calculateUserAccountData, currentReserveAddress ==address(0)', async () => {
-    /**
-     * Unsure how we can get to a state where this is testable.
-     * We need to add a reserve with address(0), but we cannot add a reserve with address(0),
-     * because we are checking for that when we init a reserve.
-     * We can make a drop of the reserve, to get address(0), but this can only be done when
-     * there is no deposit and borrows. And without those, the `isUsingAsCollateralOrBorrowing` will make us ship the case
-     */
-    expect(false, 'IMPOSSIBLE').to.be.eq(true);
-  });
-
   it('_addReserveToList() already added', async () => {
     /**
      * To get into this case, we need to init a reserve with `aTokenAddress = address(0)` twice.
@@ -196,6 +185,7 @@ makeSuite('Pool - edge cases', (testEnv: TestEnv) => {
   });
 
   it('_addReserveToList() reservesCount > _maxNumberOfReserves', async () => {
+    // TODO: For the love of god, let is make something more nice here.
     // Really a pain, but practically, we just want to loop until we hit something high?
     const { pool, dai, deployer, configurator } = testEnv;
 

test-suites/validation-logic.spec.ts

@@ -76,16 +76,6 @@ makeSuite('Validation-logic: reverting edge cases', (testEnv: TestEnv) => {
     ).to.be.revertedWith(VL_RESERVE_FROZEN);
   });
 
-  it('validateWithdraw() isActive == false', async () => {
-    /**
-     * Unclear how we should ever enter this stage. Only possible to get to `isActive == false` if
-     * `availableLiquidity == 0 && reserveData.currentLiquidityRate == 0`, but this require that there are no funds.
-     * And if there is no funds, we are stopped earlier in the validation.
-     */
-
-    expect(false, 'Impossible to reach').to.be.eq(true);
-  });
-
   it('validateBorrow() vars.isActive == false', async () => {
     /**
      * Unclear how we should enter this stage with normal usage.