Some fixes. #3
Open
Some fixes. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abellina
pushed a commit
that referenced
this pull request
Dec 9, 2022
* Hive Text parsing of invalid date strings should not cause exceptions. Fixes NVIDIA#7089. There were two problems: 1. Strings between field delimiters should not be trimmed before casting to dates. 2. Invalid date strings should not be causing exceptions. They should return null values, as is the convention in Hive's `LazySimpleSerDe`. Signed-off-by: MithunR <mythrocks@gmail.com> * Fixed verify errors. * Fixed merge duplication. * Review fixes: 1. Fixed indentation. 2. Hardcode for supported date format. 3. Added tests for timestamp strings read as dates. 4. Fixed behaviour for #3 above. Signed-off-by: MithunR <mythrocks@gmail.com> Co-authored-by: Robert (Bobby) Evans <bobby@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor fixes to work with JUCX-1.11 API + use some new SparkUCX API