Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix child's ref #2

Merged
merged 1 commit into from
Jun 17, 2018
Merged

Fix child's ref #2

merged 1 commit into from
Jun 17, 2018

Conversation

goldylucks
Copy link
Contributor

current behavior overrides the child's ref. Read this for more info.

@goldylucks
Fix child's ref
7ec9e51 
current behavior overrides the child's ref. [Read this](facebook/react#8873 (comment)) for more info.
rheaditi
rheaditi reviewed Apr 15, 2018
View reviewed changes
Copy link
Collaborator

@rheaditi rheaditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Will test this and release it in the next version. Thanks a lot for the PR! 🙇

@abinavseelan
Copy link
Owner

@rheaditi 👍

@goldylucks Thank you 🙇

@erodactyl
Copy link

+1

abinavseelan
abinavseelan approved these changes Jun 17, 2018
View reviewed changes
Copy link
Owner

@abinavseelan abinavseelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! 🙂

@abinavseelan abinavseelan merged commit a139e00 into abinavseelan:master Jun 17, 2018
@goldylucks goldylucks deleted the patch-1 branch June 17, 2018 10:53
@goldylucks
Copy link
Contributor Author

My pleasure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rheaditi rheaditi rheaditi left review comments

@abinavseelan abinavseelan abinavseelan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goldylucks @abinavseelan @erodactyl @rheaditi