Introduce output data format versioning #2653 #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add output data format version numbers to the headers and version help text. Introduce new command line option to switch to the new experimental data format. Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
2653-output-data-format-version
branch
from
591a728
to
2a00b47
Compare
Modifies tests to ignore addition of output data format in headers. Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Renames flag to --future-format and updates help text test. Adds future format version. Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
2653-output-data-format-version
branch
from
c3ad331
to
588ac9d
Compare
|
@pombredanne could you look into this why the tests with If I change this to What am I doing wrong here |
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
pombredanne
reviewed
Sep 6, 2021
src/scancode/cli.py
Outdated
| @@ -249,6 +251,13 @@ def validate_depth(ctx, param, value): | |||
| 'the starting directory. Use 0 for no scan depth limit.', | |||
| help_group=cliutils.CORE_GROUP, sort_order=301, cls=PluggableCommandLineOption) | |||
|
|
|||
| @click.option('--future-format', | |||
| is_flag=True, | |||
| help='Output the next experimental data format, for JSON and YAML output.' | |||
There was a problem hiding this comment.
Use future and not experimental, here and elsewhere
pombredanne
reviewed
Sep 6, 2021
src/scancode_config.py
Outdated
|
|
||
| # See https://github.com/nexB/scancode-toolkit/issues/2653 for more information | ||
| # on the data format version | ||
| __output_format_version__ = '1.1' |
You need to push 21.8.31 to PyPI too IMHO |
pombredanne
requested changes
Sep 6, 2021
There was a problem hiding this comment.
IMHO you could have fewer changes in the diffs if def check_json_scan(..., ignore_headers=True) was updated to be def check_json_scan(..., include_headers=False) this way few changes are needed in the tests overall... and only a few tests that test headers will need fixing.
You have to add me at https://pypi.org/project/commoncode/ btw |
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
2653-output-data-format-version
branch
2 times, most recently
from
72ab891
to
a93fd62
Compare
Replaces ignore_header with check_header attribute with default False, to minimise diff and ignore headers by default. Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
See #2653 (comment) Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
2653-output-data-format-version
branch
from
e5da48f
to
457f782
Compare
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
pombredanne
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add output data format version numbers to the headers and version help
text. Introduce new command line option to switch to the new experimental
data format.
Signed-off-by: Ayan Sinha Mahapatra ayansmahapatra@gmail.com