Angular - Datatable Loading Indicator Updates #20804
Open
+162
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masum-ulu
requested changes
Sep 13, 2024
masum-ulu
reviewed
Sep 16, 2024
...ages/components/extensible/src/lib/components/extensible-table/extensible-table.component.ts
Outdated
Show resolved
Hide resolved
masum-ulu
reviewed
Sep 16, 2024
npm/ng-packs/packages/theme-shared/src/lib/components/spinner/spinner.component.ts
Outdated
Show resolved
Hide resolved
masum-ulu
reviewed
Sep 16, 2024
npm/ng-packs/packages/theme-shared/src/lib/components/spinner/spinner.component.ts
Outdated
Show resolved
Hide resolved
masum-ulu
reviewed
Sep 16, 2024
npm/ng-packs/packages/theme-shared/src/lib/directives/ngx-datatable-list.directive.ts
Outdated
Show resolved
Hide resolved
masum-ulu
requested changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the
ngx-datatableimplementation bu modifying the loading indicator (progress) to show a customized spinner.Checklist
How to test it?
copy-to:appcommand and test the tables as demonstrated in the record.