Improve Github actions #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfinus
changed the title
binaryseed
requested changes
Mar 22, 2021
|
Done. |
binaryseed
requested changes
Mar 22, 2021
binaryseed
approved these changes
Mar 22, 2021
|
Thanks! |
This was referenced Mar 22, 2021
Merged
|
I've also added a PR into some other absinthe repos with the same actions set: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
It looks like commiting to branches excluding
masterdoes not run Github Actions. So users which are working on feature/bugfix branches cannot see that their changes are leading to failed tests until they'll create a pull request to master branch.So I've removed restriction against branch name for
pushevents.Also I've found another quite annoying bug - step
actions/cachedoes not update cache item if it was restored using a primary key.For example, some dependencies like dialyzer or other ones store their files in
depsor_buildfolders (which are cached in the workflow). But when these dependencies perform some updates of these folders, it does not lead to the updating ofmix.lockfile. File hasn't been changed -> hash is the same -> cache primary key is the same -> caching action will not update the existing cache.This will cause the increase of workflow run time because the stored cache will not be used by some steps. Until
mix.lockwill be updated which will lead to updating the cache item.Here I've appended a commit SHA to the cache primary key, so it will always be updated. But it will not affect cache reading.
What do you think about that?