Merge pull request #147 from absinthe-graphql/bugfix-async-behavior

Bugfix async behavior

.tool-versions

@@ -1,2 +1,2 @@
-elixir 1.13.0-rc.1-otp-24 1.12.0-otp-24
+elixir 1.14.1-otp-24 1.12.0-otp-24
 erlang 24.1.7 24.1.5 24.1.2 24.1.1 24.0

lib/dataloader.ex

@@ -175,7 +175,8 @@ defmodule Dataloader do
             sync_sources,
             fun,
             [
-              timeout: dataloader_timeout(dataloader)
+              timeout: dataloader_timeout(dataloader),
+              async?: false
             ]
           ],
           async?: false

test/dataloader/ecto_test.exs

@@ -535,4 +535,29 @@ defmodule Dataloader.EctoTest do
     assert Enum.map(users, &Dataloader.get(loader, Test, {User, id: &1.id}, &1.id)) ==
              users
   end
+
+  test "run inside transaction" do
+    user = %User{username: "Ben Wilson"} |> Repo.insert!()
+
+    source = Dataloader.Ecto.new(Repo, async: false)
+
+    loader =
+      Dataloader.new(async: false)
+      |> Dataloader.add_source(Test, source)
+
+    Dataloader.load(loader, Test, User, user.id)
+
+    Repo.transaction(fn ->
+      loader =
+        loader
+        |> Dataloader.load(Test, User, user.id)
+        |> Dataloader.run()
+
+      loaded =
+        loader
+        |> Dataloader.get(Test, User, user.id)
+
+      assert ^user = loaded
+    end)
+  end
 end