fix(serializers): undo 9854471

Turns out, using a separate ListSerializer does not help at all but breaks some stuff. So we simply include the references in the list output to have them in the swagger file.
acdh-oeaw · Jul 4, 2024 · 6ff6b44 · 6ff6b44
1 parent fb48128
commit 6ff6b44
Showing 1 changed file with 7 additions and 46 deletions.
diff --git a/apis_ontology/serializers.py b/apis_ontology/serializers.py
@@ -85,6 +85,7 @@ class SicprodSerializer(GenericHyperlinkedModelSerializer):
     def get_fields(self):
         fields = super().get_fields()
         fields["relation_types"] = serializers.SerializerMethodField(method_name="get_relation_types")
+        fields["references"] = serializers.SerializerMethodField(method_name="get_references")
         return fields
 
     def get_relation_types(self, obj) -> list[str]:
@@ -99,78 +100,38 @@ def get_relation_types(self, obj) -> list[str]:
             relations.add(reltype)
         return relations
 
-
-class ReferencesMixin(serializers.Serializer):
-    references = serializers.SerializerMethodField(method_name="get_references")
-
     @extend_schema_field(SimplifiedReferenceSerializer(many=True))
     def get_references(self, obj):
         ct = ContentType.objects.get_for_model(obj)
         references = Reference.objects.filter(content_type=ct, object_id=obj.id)
         return SimplifiedReferenceSerializer(references, many=True).data
 
 
-class EventListSerializer(SicprodSerializer, serializers.ListSerializer):
+class EventSerializer(SicprodSerializer):
     class Meta:
         fields = ["id", "name", "start_date_written", "end_date_written", "type"]
 
 
-class EventSerializer(ReferencesMixin, SicprodSerializer):
-    class Meta:
-        fields = ["id", "name", "start_date_written", "end_date_written", "type", "references"]
-        list_serializer_class = EventListSerializer
-
-
-class FunctionListSerializer(SicprodSerializer, serializers.ListSerializer):
+class FunctionSerializer(SicprodSerializer):
     class Meta:
         fields = ["id", "name", "start_date_written", "end_date_written", "alternative_label"]
 
 
-class FunctionSerializer(ReferencesMixin, SicprodSerializer):
-    class Meta:
-        fields = ["id", "name", "start_date_written", "end_date_written", "alternative_label", "references"]
-        list_serializer_class = FunctionListSerializer
-
-
-class InstitutionListSerializer(SicprodSerializer, serializers.ListSerializer):
+class InstitutionSerializer(SicprodSerializer):
     class Meta:
         fields = ["id", "name", "start_date_written", "end_date_written", "type", "alternative_label"]
 
 
-class InstitutionSerializer(ReferencesMixin, SicprodSerializer):
-    class Meta:
-        fields = ["id", "name", "start_date_written", "end_date_written", "type", "alternative_label", "references"]
-        list_serializer_class = InstitutionListSerializer
-
-
-class PersonListSerializer(SicprodSerializer, serializers.ListSerializer):
+class PersonSerializer(SicprodSerializer):
     class Meta:
         fields = ["id", "url", "name", "start_date_written", "end_date_written", "status", "first_name", "gender", "alternative_label"]
 
 
-class PersonSerializer(ReferencesMixin, SicprodSerializer):
-    class Meta:
-        fields = ["id", "url", "name", "start_date_written", "end_date_written", "status", "first_name", "gender", "alternative_label", "references"]
-        list_serializer_class = PersonListSerializer
-
-
-class PlaceListSerializer(SicprodSerializer, serializers.ListSerializer):
+class PlaceSerializer(SicprodSerializer):
     class Meta:
         fields = ["id", "name", "start_date_written", "end_date_written", "type", "longitude", "latitude", "alternative_label"]
 
 
-class PlaceSerializer(ReferencesMixin, SicprodSerializer):
-    class Meta:
-        fields = ["id", "name", "start_date_written", "end_date_written", "type", "longitude", "latitude", "alternative_label", "references"]
-        list_serializer_class = PlaceListSerializer
-
-
-class SalaryListSerializer(SicprodSerializer, serializers.ListSerializer):
+class SalarySerializer(SicprodSerializer):
     class Meta:
         fields = ["id", "name", "start_date_written", "end_date_written", "typ", "repetitionType"]
-
-
-class SalarySerializer(ReferencesMixin, SicprodSerializer):
-    class Meta:
-        fields = ["id", "name", "start_date_written", "end_date_written", "typ", "repetitionType", "references"]
-        list_serializer_class = SalaryListSerializer