This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
Make branch return a stateless functional component #273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure you would want to merge this but at least, I will learn something out of the discussion!
Currently,
branch
returns a full-fledged React component. I am wondering whether it could return a stateless functional component instead (which is interesting because the component could be eagerly rendered).That would essentially mean that we would be fine with factories being (lazily) initialized in
render
instead of the component's constructor and thewillComponentReceiveProps
hook—is it the case?