-
Notifications
You must be signed in to change notification settings - Fork 1.3k
componentFromStream can potentially throw EmptyError: no elements in sequence #309
Conversation
are u sure https://github.com/acdlite/recompose/blob/master/src/packages/recompose/componentFromStream.js#L41 |
Had this problem in my project after update. It was cause with |
Ill add a ref to this thread here https://github.com/acdlite/recompose/releases/tag/v0.22.0 |
Done, thank you. |
Done
I thought it would be good for new users to know about this gotcha. And yes, for old users release description is better place. |
May we move changes from documentation into first comment here and Ill merge the test only? |
I think for new users it will be well described understandable rx error, isnt it? |
componentFromStream()
Or may be change documentation as now its not obvious why such exception should occur |
Done
I'm not good at documenting things :). |
A rare persons are good in documentation. My own projects some kind of documentation hell ;-) |
Thank you!!! |
As from 0.22.0
componentFromStream
will complete the stream during unmount and usage of first, last or single methods can potentially throw EmptyError.See #220 and #303