Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo/Dragging - Add Flexible Fuel Tanks cargo/dragging #8604

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Cargo/Dragging - Add Flexible Fuel Tanks cargo/dragging #8604

merged 3 commits into from
Oct 25, 2021

Conversation

dedmen
Copy link
Contributor

@dedmen dedmen commented Oct 24, 2021

Make 300L flexible fueltanks cargo loadable and draggable.

I'm not sure if cargo size 3 is correct, they are really heavy of course, but not actually that large.
Arma3Retail_DX11_x64_Yx67VJ3vlB

@dedmen
Copy link
Contributor Author

dedmen commented Oct 24, 2021 •
edited
Loading

Considering that these weigh 300, and the default ACE_maxWeightCarry is 600, should these also be carryable?
I think its a bit unrealistic to carry a 300L fuel container, but the default max is set to 600 so it already is unrealistic.

ACE3/addons/dragging/XEH_postInit.sqf

Line 16 in 76676ee

ACE_maxWeightCarry = 600; 

GVAR(canCarry) = 1;
GVAR(carryPosition)[] = {0,0.65,0};

(raised up, lowest position is exactly on floor)
Arma3Retail_DX11_x64_G19nRiPfE6

@dedmen
Copy link
Contributor Author

dedmen commented Oct 24, 2021

I put carrying in for now, we can take it out again if not wanted

@dedmen dedmen mentioned this pull request Oct 24, 2021
Merged
@veteran29 veteran29 added the kind/enhancement Release Notes: **IMPROVED:** label Oct 24, 2021
@veteran29 veteran29 added this to the Ongoing milestone Oct 24, 2021
veteran29
veteran29 approved these changes Oct 24, 2021
View reviewed changes
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think carrying is okay.

LGTM

jonpas
jonpas approved these changes Oct 24, 2021
View reviewed changes
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems heavy, but we don't simulate multiple people carrying, so good enough trade-off I guess.

@jonpas jonpas changed the title Add flexible fueltanks cargo/dragging Cargo/Dragging - Add Flexible Fuel Tanks cargo/dragging Oct 24, 2021
@PabstMirror PabstMirror modified the milestones: Ongoing, 3.14.1 Oct 24, 2021
@Drofseh
Copy link
Contributor

Drofseh commented Oct 24, 2021

300 L of gasoline weighs around 225 KG, I think carrying might be a bit much.
No sure what the dry weight of the container would be, 5 KG maybe?

@PabstMirror PabstMirror merged commit 2ff27d8 into acemod:master Oct 25, 2021
AndreasBrostrom pushed a commit to AndreasBrostrom/ACE3 that referenced this pull request Dec 3, 2021
@dedmen @AndreasBrostrom
Cargo/Dragging - Add Flexible Fuel Tanks cargo/dragging (acemod#8604)
de46f0d 
* Add flexible fueltanks cargo/dragging

* Use proper macros in cargo

* Enable carrying
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veteran29 veteran29 veteran29 approved these changes

@jonpas jonpas jonpas approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

@mharis001 mharis001 mharis001 approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.14.1
Development

Successfully merging this pull request may close these issues.
6 participants
@dedmen @Drofseh @veteran29 @jonpas @PabstMirror @mharis001