-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2214: BLT doctor detect alias files. #2221
Conversation
Instead of looking for the alias file, maybe just use the inspector function or invoke drush sa... or get rid of the check completely, if the inspector would catch such a problem anyway. |
359769a
to
9c15905
Compare
For some reason, when Executor::drush() runs a command against a remote alias (VM), it always fails with an obscure error that I can't reproduce when running the same command normally. I'm guessing when the SSH session is terminated, it's interpreted as an error. I think the best option is to try replacing it with drush_invoke_process(). |
Blocked: drush-ops/drush#3127 Although interestingly, we have the problem in BLT even though BLT doesn't explicitly call Drush with the non-interactive parameter. It must be implied somehow. I'll have to pull that thread. Edit: must be due to Symfony setting TTY mode |
Looks like we have a fix for that now, but we'll have to decide whether we want to patch drush or wait for beta9 (or merge this as-is and come back to it later when beta9 drops). |
* Don't check if Drush alias exists. * Fix alias logic.
WIP, this is going to require a little bit of thought