Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2214: BLT doctor detect alias files. #2221

Merged
merged 3 commits into from
Nov 3, 2017

Conversation

danepowell
Copy link
Contributor

WIP, this is going to require a little bit of thought

@danepowell
Copy link
Contributor Author

Instead of looking for the alias file, maybe just use the inspector function or invoke drush sa... or get rid of the check completely, if the inspector would catch such a problem anyway.

@danepowell
Copy link
Contributor Author

For some reason, when Executor::drush() runs a command against a remote alias (VM), it always fails with an obscure error that I can't reproduce when running the same command normally. I'm guessing when the SSH session is terminated, it's interpreted as an error.

I think the best option is to try replacing it with drush_invoke_process().

@danepowell
Copy link
Contributor Author

danepowell commented Nov 1, 2017

Blocked: drush-ops/drush#3127

Although interestingly, we have the problem in BLT even though BLT doesn't explicitly call Drush with the non-interactive parameter. It must be implied somehow. I'll have to pull that thread.

Edit: must be due to Symfony setting TTY mode

@danepowell
Copy link
Contributor Author

Looks like we have a fix for that now, but we'll have to decide whether we want to patch drush or wait for beta9 (or merge this as-is and come back to it later when beta9 drops).

@danepowell danepowell removed the blocked label Nov 3, 2017
@danepowell danepowell merged commit 5f6604c into acquia:9.1.x Nov 3, 2017
@danepowell danepowell deleted the issue-2214-9.1.x branch December 6, 2017 00:30
danepowell added a commit to danepowell/blt that referenced this pull request Dec 12, 2017
* Don't check if Drush alias exists.

* Fix alias logic.
danepowell added a commit that referenced this pull request Dec 12, 2017
* Don't check if Drush alias exists.

* Fix alias logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants