Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force the use of the bc signer #83

Merged
merged 7 commits into from
Sep 6, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
danjelalura marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
distribution: 'temurin'

- name: Build with Maven
run: mvn clean deploy -P sign -Dgpg.signer=bc
run: mvn clean deploy -P sign
danjelalura marked this conversation as resolved.
Show resolved Hide resolved
env:
MAVEN_GPG_KEY: ${{ secrets.CODE_SIGNING_PRIV_KEY }}
MAVEN_GPG_PASSPHRASE: ${{ secrets.CODE_SIGNING_PWD }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,4 @@ jobs:
git config user.email opensource@acrolinx.com
git config user.name $GIT_USER_NAME
git checkout -b $PR_BRANCH_NAME
mvn -s .m2/settings.xml -P sign -B -Dusername=$GIT_USER_NAME -Dpassword=$GITHUB_TOKEN -DpreparationGoals="clean spotless:apply verify" -DcompletionGoals="spotless:apply" release:prepare release:perform -Dgpg.signer=bc -e
mvn -s .m2/settings.xml -P sign -B -Dusername=$GIT_USER_NAME -Dpassword=$GITHUB_TOKEN -DpreparationGoals="clean spotless:apply verify" -DcompletionGoals="spotless:apply" release:prepare release:perform
3 changes: 3 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,9 @@
<goal>sign</goal>
</goals>
<phase>verify</phase>
<configuration>
<signer>bc</signer>
</configuration>
</execution>
</executions>
</plugin>
Expand Down