Improve expression validation for short-circuiting expressions #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we are removing the short-circuiting behavior of the expression validate. Previously for an expression like
we showed only the first invalid context access, not the second one since we were using the unmodified expression evaluator and that's the correct behavior at run-/evaluation time. Now we are removing that behavior during validation and capture more of the errors.
We could also provide more targeted error ranges, like highlighting only the specific part of the extension that's invalid, similar to the hover behavior but that's left for a future change.
CleanShot.2023-04-05.at.13.53.00.mp4
Closes: github/vscode-github-actions#61