Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch side by side testing example to single setup step #283

Merged
merged 1 commit into from
Apr 11, 2022
Merged

switch side by side testing example to single setup step #283

merged 1 commit into from
Apr 11, 2022

Conversation

adamralph
Copy link
Contributor

@adamralph adamralph commented Apr 10, 2022 •
edited
Loading

Description:
Since multiple versions were introduced, there's no need to run two setup steps anymore.

Related issue:
#146

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@adamralph adamralph requested a review from a team April 10, 2022 21:15
@vsafonkin
Copy link

cc: @brcrista

brcrista
brcrista approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@brcrista brcrista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brcrista brcrista merged commit 9283a8c into actions:main Apr 11, 2022
@adamralph adamralph deleted the patch-1 branch April 11, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsafonkin vsafonkin vsafonkin approved these changes

@brcrista brcrista brcrista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamralph @vsafonkin @brcrista