Fix the bug about parsing dragonwell version (#642)

actions · Jul 1, 2024 · a3c03fb · a3c03fb
1 parent fd08b9c
commit a3c03fb
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/dist/setup/index.js b/dist/setup/index.js
@@ -124232,7 +124232,16 @@ class DragonwellDistribution extends base_installer_1.JavaBase {
                 // Some version of Dragonwell JDK are numerated with help of non-semver notation (more then 3 digits).
                 // Common practice is to transform excess digits to the so-called semver build part, which is prefixed with the plus sign, to be able to operate with them using semver tools.
                 if (jdkVersion.split('.').length > 3) {
-                    jdkVersion = (0, util_1.convertVersionToSemver)(jdkVersion);
+                    const jdkVersionNums = jdkVersion.split('.');
+                    const splitedJdkVersionList = jdkVersionNums.slice(0, 3);
+                    if (jdkVersion.includes('+')) {
+                        const buildParts = jdkVersion.split('+');
+                        splitedJdkVersionList.push(buildParts[buildParts.length - 1]);
+                    }
+                    else {
+                        splitedJdkVersionList.push(jdkVersionNums[jdkVersionNums.length - 1]);
+                    }
+                    jdkVersion = (0, util_1.convertVersionToSemver)(splitedJdkVersionList.join('.'));
                 }
                 for (const edition in archMap) {
                     eligibleVersions.push({

diff --git a/src/distributions/dragonwell/installer.ts b/src/distributions/dragonwell/installer.ts
@@ -150,7 +150,17 @@ export class DragonwellDistribution extends JavaBase {
         // Some version of Dragonwell JDK are numerated with help of non-semver notation (more then 3 digits).
         // Common practice is to transform excess digits to the so-called semver build part, which is prefixed with the plus sign, to be able to operate with them using semver tools.
         if (jdkVersion.split('.').length > 3) {
-          jdkVersion = convertVersionToSemver(jdkVersion);
+          const jdkVersionNums: string[] = jdkVersion.split('.');
+          const splitedJdkVersionList: string[] = jdkVersionNums.slice(0, 3);
+          if (jdkVersion.includes('+')) {
+            const buildParts: string[] = jdkVersion.split('+');
+            splitedJdkVersionList.push(buildParts[buildParts.length - 1]);
+          } else {
+            splitedJdkVersionList.push(
+              jdkVersionNums[jdkVersionNums.length - 1]
+            );
+          }
+          jdkVersion = convertVersionToSemver(splitedJdkVersionList.join('.'));
         }
 
         for (const edition in archMap) {