[Bugfix] Remove stale when updated without comment #717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing logic for
remove-stale-when-updated
only considers presence of comments, ignoring the presence of any other kind of update.This fixes it so it follows the documented behaviour for that setting.
There is no effect from this change on tests (all pass). I suspect that the tests simply do not cover the case of updates, only comments; the new logic is equivalent to the old one for the case of new comments.
I would have included new tests to add to the coverage, but I have no idea how to achieve that as this is my first time ever touching TypeScript code.
Changes
issueHasUpdate
Context
Fixes #715