[bug] Symlinks are preserved by default #590
Labels
bug
Something isn't working
Comments
daskol
added a commit
to nntile/nntile
that referenced
this issue
Aug 3, 2024
Action `action/upload-artifact` with new release no longer dereferences symlinks by default. See actions/upload-artifact#590 for details.
daskol
added a commit
to nntile/nntile
that referenced
this issue
Aug 3, 2024
Action `action/upload-artifact` with new release no longer dereferences symlinks by default. See actions/upload-artifact#590 for details.
|
This also affected us. Thanks @daskol for reporting this issue. |
|
#589 Seems the same issue. |
|
Hi there! Riccardo from Meta, working in the React team and taking care of the React Native build pipeline on GH. |
|
@robherley Could we revert the changes in the latest release 4.3.5 and create a new release 4.3.6? After that, we can continue working on this issue. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this issue
Aug 6, 2024
Summary: We had CI on main failing consistently the past couple of days. The problem is that the hermes pipeline is failing to create the iOS XCFramework with the error: > unable to create a Mach-O from the binary at '/Users/runner/work/react-native/react-native/packages/react-native/sdks/hermes/destroot/Library/Frameworks/catalyst/hermes.framework/hermes' The main cause is this upgrade of [upload-artifacts](actions/upload-artifact#590) which breaks symlinks. The solution is to bump the caches and downgrade the `upload-artifact` actions. ## Changelog: [Internal] - Try to fix CI for Hermes Pull Request resolved: #45908 Test Plan: GHA must be green Reviewed By: cortinico Differential Revision: D60828616 Pulled By: cipolleschi fbshipit-source-id: 6976b86dd67e2fd9d806ebaa62f47e39dc44b30d
|
Hey folks, we reverted & released a new version for v4.3.6 to address the regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
Transition from v4.3.4 to v4.3.5 broke regular building pipelines because
actions/upload-artifactdoes not derefernce symlink anymore by default and upload symlinks as is but not target files.See "Upload StarPU libraries" job for details.
What did you expect to happen?
How can we reproduce it?
You can fork repo or create pull request and trigger pipeline on push event.
Anything else we need to know?
No response
What version of the action are you using?
v4.3.5 (no issue with the previous v4.3.4)
What are your runner environments?
linux
Are you on GitHub Enterprise Server? If so, what version?
No response
The text was updated successfully, but these errors were encountered: