-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jazz cash wallet payment icon #1231
base: master
Are you sure you want to change the base?
jazz cash wallet payment icon #1231
Conversation
Hi @SyedAzeemAbbas , are you able to correct the following issue in the SVG? Failure: |
sure why not i am resolving this issue |
hi @dannye0231 I have resolved SVG issue |
Hi @SyedAzeemAbbas , are you able to check the other error that is now showing up? Failure: |
yes i have gone through it and resolved this issue
…On Mon, Sep 30, 2024 at 11:43 PM Danny Elisha ***@***.***> wrote:
Hi @SyedAzeemAbbas <https://github.com/SyedAzeemAbbas> , are you able to
check the other error that is now showing up?
Failure:
PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements
[test/unit/payment_icon_test.rb:89]:
{:message=>"The 'textGradient' ID should be pi-jazzcash-textGradient
(missing 'pi-' prefix)"}.
Expected /pi-(.*)/ to match "textGradient".
—
Reply to this email directly, view it on GitHub
<#1231 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACW7JJLSV5HPFBXESTLXS5TZZGLVFAVCNFSM6AAAAABPA4OSLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBTHEYTINRXGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*Syed Azeem Abbas*
*+92 3453677361*
|
Why are you adding this icons?
I'm adding/updating this icon(s) because ..
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?