Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Askama/actix-web integration into actix-web #1072

Closed
djc opened this issue Sep 5, 2019 · 3 comments
Closed

Move Askama/actix-web integration into actix-web #1072

djc opened this issue Sep 5, 2019 · 3 comments

Comments

@djc
Copy link

djc commented Sep 5, 2019

I have been struggling with the Askama integrations for different web frameworks. For now, Askama is not available for actix-web 1.0 because there are conflicting dependencies between actix-web/Gotham/Rocket, all of which Askama supports. Due to coherency issues, I think the integration code will have to live inside either actix-web or Askama. I'd still be happy to do any maintenance work required on the integration, but at this point I think it would be better if the actix-web/Askama integration moves into the actix-web crate (since the latter has many more requirements on the dependency tree than Askama itself).

@fafhrd91
Copy link
Member

fafhrd91 commented Sep 5, 2019

I am fine with moving askama support to actix-web repo.

@fafhrd91
Copy link
Member

Anyone want to take this task?

@actix/contributors

@fafhrd91
Copy link
Member

whoever wants to help with this just open PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants