Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support actix-web v1.0 #246

Closed
NfNitLoop opened this issue Jun 9, 2019 · 3 comments · Fixed by #286
Closed

Support actix-web v1.0 #246

NfNitLoop opened this issue Jun 9, 2019 · 3 comments · Fixed by #286

Comments

@NfNitLoop
Copy link

The feature = ["with-actix-web"] functionality currently depends on actix-web v0.7.0, and won't work with v1.0.

I tried updating the dependency locally, and it looks like the interface of actix-web's Responder trait changed in 1.0. (v1.0 vs. v0.7)
@djc
Copy link
Owner

djc commented Jun 9, 2019

Right now this will also fail CI since a dependency conflicts with a Gotham dependency (see #234).

@ZanderBrown
Copy link

Any progress on this?

@djc
Copy link
Owner

djc commented Sep 5, 2019

I'm afraid there's no good way to split this stuff. At this point I'd prefer to move the integrations into their respective upstreams if possible to make sure Askama doesn't have to build a dependency graph that has to work across 3+ web frameworks. Filed actix/actix-web#1072.

@DCjanus DCjanus mentioned this issue Jan 11, 2020
Merged
@djc djc closed this as completed in #286 Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgrade dependencies(actix-web 0.7 -> 2, bytes 0.4 -> 0.5)
3 participants
@djc @NfNitLoop @ZanderBrown