Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade dependencies(actix-web 0.7 -> 2, bytes 0.4 -> 0.5) #286

Merged
merged 2 commits into from
Jan 11, 2020
Merged

upgrade dependencies(actix-web 0.7 -> 2, bytes 0.4 -> 0.5) #286

merged 2 commits into from
Jan 11, 2020

Conversation

DCjanus
Copy link
Contributor

@DCjanus DCjanus commented Jan 11, 2020 •
edited
Loading

Close #246

@DCjanus DCjanus changed the title WIP: upgrade dependencies(actix-web 0.7 -> 2) WIP: upgrade dependencies Jan 11, 2020
@DCjanus DCjanus changed the title WIP: upgrade dependencies upgrade dependencies(actix-web 0.7 -> 2) Jan 11, 2020
@DCjanus DCjanus changed the title upgrade dependencies(actix-web 0.7 -> 2) upgrade dependencies(actix-web 0.7 -> 2, bytes 0.4 -> 0.5) Jan 11, 2020
@DCjanus
Copy link
Contributor Author

DCjanus commented Jan 11, 2020 •
edited
Loading

maybe #254 would be a better idea, I'd like to handle this.

@DCjanus DCjanus closed this Jan 11, 2020
@djc
Copy link
Owner

djc commented Jan 11, 2020

Awesome, thanks!

@djc
Copy link
Owner

djc commented Jan 11, 2020

I think the split cannot work or is quite tricky. I'd like to get the upgrade in anyway!

@DCjanus
Copy link
Contributor Author

DCjanus commented Jan 11, 2020 •
edited
Loading

You are right, tried and gave up :)

@DCjanus DCjanus reopened this Jan 11, 2020
@djc djc merged commit 100679e into djc:master Jan 11, 2020
@DCjanus
Copy link
Contributor Author

DCjanus commented Jan 11, 2020

BTW, maybe we should remove gotham support, looks like it is no longer in active maintenance.

@djc
Copy link
Owner

djc commented Jan 11, 2020

As for Gotham, looks like their latest commit to master was 10 days ago - that hardly seems dead to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support actix-web v1.0
2 participants
@DCjanus @djc