Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Split integrations into separate crates #254

Closed
wants to merge 2 commits into from

Conversation

fabianfreyer
Copy link

@fabianfreyer fabianfreyer commented Jul 19, 2019

See discussion in #234. This is a first attempt at splitting out some of the integrations - I'm not sure this is the right way though.

  • Split out actix-web
  • Split out gotham
  • Split out rocket
  • Split out iron

@djc
Copy link
Owner

djc commented Jul 20, 2019

This looks great! I'd like to move the actix tests into askama-actix as well. Also I think as the author of most of the code in askama-actix, I think I should be part of the authors in the crate metadata? Also it looks like askama-actix uses extern crate more than necessary in 2018 Rust.

@fabianfreyer
Copy link
Author

fabianfreyer commented Jul 20, 2019

This looks great!

Hmm, the tests don't pass yet though, it currently fails with:

error[E0277]: the trait bound `tests::HelloTemplate<'_>: actix_web::handler::Responder` is not satisfied
  --> askama_actix/src/lib.rs:79:55
   |
79 |         let mut srv = test::TestServer::new(|app| app.handler(|_| HelloTemplate { name: "world" }));
   |                                                       ^^^^^^^ the trait `actix_web::handler::Responder` is not implemented for `tests::HelloTemplate<'_>`

I'd like to move the actix tests into askama-actix as well.

Yep, this sounds like a good idea!

Also I think as the author of most of the code in askama-actix, I think I should be part of the authors in the crate metadata?

Of course! I hadn't done much in the Cargo.toml yet - just poking around to make sure this approach works for now.

Also it looks like askama-actix uses extern crate more than necessary in 2018 Rust.

Ah, good point, I'll remove that

@djc
Copy link
Owner

djc commented Jan 29, 2020

This was finally fixed in #255. Thanks for working on it with me!

@djc djc closed this Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants