Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] bump actix-web to 1.0 #234

Closed
wants to merge 1 commit into from

Conversation

fabianfreyer
Copy link

@fabianfreyer fabianfreyer commented Apr 22, 2019

actix-0.8 does not work with actix-web 0.7, but requires actix-web 1.0. However, this is still in beta, and has a conflict on ring which is pulled in via cookie and actix-http.

Therefore, merge when:

@djc
Copy link
Owner

djc commented Apr 23, 2019

Thanks for the PR! Please help remind me when those issues clear out...

@fafhrd91
Copy link

Just fyi, actix-web does not depend on cookie crate anymore

@fabianfreyer
Copy link
Author

Just fyi, actix-web does not depend on cookie crate anymore

ascama_testing depends on gotham, which has a dependency on cookie.

@fabianfreyer
Copy link
Author

It seems we are having the same problem with rocket (#252).

@djc
Copy link
Owner

djc commented Jul 19, 2019

I'm inclined to split out the integration code into separate crates (as in askama-actix, askama-rocket, askama-gotham) to solve this problem, because this is will only get worse over time probably.

@fabianfreyer
Copy link
Author

Agreed, that may be a sensible way forward. Should I close this PR then?

@djc
Copy link
Owner

djc commented Jul 19, 2019

I think that would make sense. If you want to go ahead and add an askama-actix crate to the repo that reexports the Template type, the derive macro and whatever integrations are necessary, that would be great!

@djc djc closed this Jul 19, 2019
@fabianfreyer
Copy link
Author

I'm not sure I follow. Shouldn't the actix-relevant stuff be moved there then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants