-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] bump actix-web to 1.0 #234
Conversation
6a4bdf9
to
7f42d6d
Compare
Thanks for the PR! Please help remind me when those issues clear out... |
Just fyi, actix-web does not depend on cookie crate anymore |
|
It seems we are having the same problem with rocket (#252). |
I'm inclined to split out the integration code into separate crates (as in askama-actix, askama-rocket, askama-gotham) to solve this problem, because this is will only get worse over time probably. |
Agreed, that may be a sensible way forward. Should I close this PR then? |
I think that would make sense. If you want to go ahead and add an askama-actix crate to the repo that reexports the |
I'm not sure I follow. Shouldn't the actix-relevant stuff be moved there then? |
actix-0.8
does not work withactix-web
0.7, but requiresactix-web
1.0. However, this is still in beta, and has a conflict onring
which is pulled in viacookie
andactix-http
.Therefore, merge when: