Fix C++20 bug in axis constructor #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reasons that I cannot fully explain, the default `multi_bin` constructor introduces a compiler error in C++20. This commit removes that constructor which seems to repair the situation.
This was referenced May 31, 2024
|
I imagine it's the |
|
I suspect it probably has something to do with P0935R0, but I'm not sure. Either way, we can fix it and enable a C++20 CI job in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons that I cannot fully explain, the default
multi_binconstructor introduces a compiler error in C++20. This commit removes that constructor which seems to repair the situation.