Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable validate on push for policybot #432

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

beomki-yeo
Copy link
Contributor

Let's see if this fixes the CI issue...

From: acts-project/acts@d6c23c6

@beomki-yeo beomki-yeo marked this pull request as draft July 20, 2023 16:53
@beomki-yeo
Copy link
Contributor Author

beomki-yeo commented Jul 20, 2023

Definitely a wrong idea...

EDIT:
Lopking at palantir/policy-bot#598, this might be the right fix. I guess the current failure is because the policy.yml of main branch is being read by policybot

@beomki-yeo beomki-yeo closed this Jul 20, 2023
@beomki-yeo beomki-yeo reopened this Jul 20, 2023
@beomki-yeo beomki-yeo marked this pull request as ready for review July 20, 2023 20:14
@beomki-yeo beomki-yeo enabled auto-merge (squash) July 20, 2023 21:17
@beomki-yeo beomki-yeo disabled auto-merge July 20, 2023 21:17
@beomki-yeo
Copy link
Contributor Author

@asalzburger @paulgessinger It seems force-merging can be done by code maintainers only

@paulgessinger
Copy link
Member

paulgessinger commented Jul 21, 2023

You mean overriding branch requirements?

EDIT: I did merge this manually now.

@paulgessinger
Copy link
Member

Concerning the policybot issue: I believe the my merged a fix now which allows disabling this globally in the installation. I can try to deploy this on Monday. Aside from that I think they have workaround for the lack of push info to invalidate in push. I'll check if that's available in their docker images yet.

@paulgessinger paulgessinger merged commit afb2317 into acts-project:main Jul 21, 2023
26 of 27 checks passed
@beomki-yeo
Copy link
Contributor Author

Sounds good. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants