Update Alpaka version, make HIP compilation work #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @CrossR |
added 3 commits
November 28, 2023 21:20
krasznaa
approved these changes
Jan 16, 2024
CMakeLists.txt
Outdated
| @@ -14,6 +14,8 @@ set( CMAKE_CXX_EXTENSIONS FALSE CACHE BOOL "Disable (host) C++ extensions" ) | |||
| set( CMAKE_CUDA_STANDARD 17 CACHE STRING "The (CUDA) C++ standard to use" ) | |||
| set( CMAKE_CUDA_EXTENSIONS FALSE CACHE BOOL "Disable (CUDA) C++ extensions" ) | |||
| set( CMAKE_SYCL_STANDARD 17 CACHE STRING "The (SYCL) C++ standard to use" ) | |||
| set( CMAKE_HIP_STANDARD 17 CACHE STRING "The (HIP) C++ standard to use" ) | |||
| set( CMAKE_HIP_EXTENSIONS FALSE CACHE BOOL "Disable (HIP) C++ extensions" ) | |||
There was a problem hiding this comment.
Since we're using VecMem's HIP support here (Unless I'm very mistaken. Unfortunately the setup is not super clear on this, as I chose the same API for VecMem's HIP support that CMake implemented eventually.), this variable doesn't really do anything. That's why I also didn't add a CMAKE_SYCL_EXTENSIONS flag. As that wouldn't do anything either.
The variable is not harmful, but it may be well be removed...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with CUDA, change the source language when compiling Alpaka with the HIP backend. Also, update the version and adapt to API changes.
Less changes than I expected in the end.