Data V6, main branch (2024.04.24.) #554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched to
v6
of the data file(s).The new file comes just with a single update wrt.
v5
. The ODD grid file was updated with the one that @niermann999 produced yesterday. 😄The new file seems to work fine. Producing seemingly the same output that we get when not using a grid at all, with some speedup. The totally non-scientific findings are:
The CUDA results I got with #552. So they don't mean terribly much right now, only that the code doesn't crash with the grid file, and that it produces the same, albeit imperfect output. In all cases I executed the "sequence example executables" with the following options:
--detector-file=geometries/odd/odd_geometry_detray.json --use-detray-detector --digitization-file=geometries/odd/odd-digi-geometric-config.json --input-directory=odd/muon100GeV-geant4/ --input-events=5
--detector-file=geometries/odd/odd_geometry_detray.json --grid-file=geometries/odd/odd_surface_grids_detray.json --use-detray-detector --digitization-file=geometries/odd/odd-digi-geometric-config.json --input-directory=odd/muon100GeV-geant4/ --input-events=5
P.S. @stephenswat I overwrote your earlier
v6
file on EOS. I consider that effort abandoned for now, for removing the cell duplicates from the CSV files themselves.