Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data V6, main branch (2024.04.24.) #554

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

krasznaa
Copy link
Member

Switched to v6 of the data file(s).

The new file comes just with a single update wrt. v5. The ODD grid file was updated with the one that @niermann999 produced yesterday. 😄

The new file seems to work fine. Producing seemingly the same output that we get when not using a grid at all, with some speedup. The totally non-scientific findings are:

Step no grid file [ms] new grid file [ms]
CPU Track Finding 7040 2148
CPU Track Fitting 2546 970
CUDA Track Finding 804 199
CUDA Track Fitting 342 67

The CUDA results I got with #552. So they don't mean terribly much right now, only that the code doesn't crash with the grid file, and that it produces the same, albeit imperfect output. In all cases I executed the "sequence example executables" with the following options:

  • No grid file: --detector-file=geometries/odd/odd_geometry_detray.json --use-detray-detector --digitization-file=geometries/odd/odd-digi-geometric-config.json --input-directory=odd/muon100GeV-geant4/ --input-events=5
  • New grid file: --detector-file=geometries/odd/odd_geometry_detray.json --grid-file=geometries/odd/odd_surface_grids_detray.json --use-detray-detector --digitization-file=geometries/odd/odd-digi-geometric-config.json --input-directory=odd/muon100GeV-geant4/ --input-events=5

P.S. @stephenswat I overwrote your earlier v6 file on EOS. I consider that effort abandoned for now, for removing the cell duplicates from the CSV files themselves.

@krasznaa krasznaa added the build This relates to the build system label Apr 24, 2024
Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in.

@krasznaa krasznaa merged commit 9f184bb into acts-project:main Apr 25, 2024
17 of 18 checks passed
@krasznaa krasznaa deleted the DataV6-main-20240424 branch April 25, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build This relates to the build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants