Add missing ACTS JSON dependency #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it stands, our CMake configuration imports ACTS without the JSON plugin component while our code depends on it. This can lead to some nasty build errors. This commit fixes the issue by correctly adding the JSON plugin dependency, allowing the build to fail early at configuration time.
stephenswat
added
bug
krasznaa
approved these changes
May 30, 2024
There was a problem hiding this comment.
Right. I never tried to build traccc against an Acts installation that would miss this plugin. 🤔
The Acts developers may say otherwise, but I think the ship has still not sailed for renaming ActsCore to Acts::Core, ActsPluginJson to Acts::PluginJson and so on. As with that naming it would always result in a CMake configuration error if somebody tried to use a component that wasn't there.
Maybe something to bring up in a wider context @asalzburger?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands, our CMake configuration imports ACTS without the JSON plugin component while our code depends on it. This can lead to some nasty build errors. This commit fixes the issue by correctly adding the JSON plugin dependency, allowing the build to fail early at configuration time.