Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update get_max_neighbor_bins to remove implicit conversion warnings #611

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Update get_max_neighbor_bins to remove implicit conversion warnings #611

merged 4 commits into from
Jun 12, 2024

Conversation

fredevb
Copy link
Contributor

@fredevb fredevb commented Jun 12, 2024 •
edited
Loading

No description provided.

@fredevb fredevb changed the title Added static cast to get_max_neighbor_bins to prevent warnings Add static_cast to get_max_neighbor_bins to prevent warnings Jun 12, 2024
@fredevb fredevb changed the title Add static_cast to get_max_neighbor_bins to prevent warnings Add static_cast in get_max_neighbor_bins to prevent warnings Jun 12, 2024
@fredevb fredevb changed the title Add static_cast in get_max_neighbor_bins to prevent warnings Add static_cast in get_max_neighbor_bins Jun 12, 2024
@fredevb @stephenswat
Update core/include/traccc/seeding/detail/seeding_config.hpp
1745207 
Co-authored-by: Stephen Nicholas Swatman <stephenswat@gmail.com>
@fredevb fredevb changed the title Add static_cast in get_max_neighbor_bins Update get_max_neighbor_bins to remove implicit conversion warnings Jun 12, 2024
stephenswat
stephenswat approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good like this.

@stephenswat stephenswat enabled auto-merge (squash) June 12, 2024 11:33
@stephenswat stephenswat enabled auto-merge (squash) June 12, 2024 11:34
@stephenswat stephenswat merged commit 6c19c24 into acts-project:main Jun 12, 2024
20 of 21 checks passed
@fredevb fredevb deleted the warning-implicit-cast-max-bins branch June 12, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krasznaa krasznaa krasznaa requested changes

@stephenswat stephenswat stephenswat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fredevb @stephenswat @krasznaa