Require multiple threads for Alpaka CCL code #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
force-pushed
the
fix/multi_thread_check
branch
from
df3c39f
to
91c92f8
Compare
|
Depends on #643. |
stephenswat
force-pushed
the
fix/multi_thread_check
branch
from
91c92f8
to
c2839eb
Compare
The CCL code currently does not support running with a single thread per block; it has to be run with multiple threads per block by design. In order to require this, I have added a new function that asserts this about a device (note that in Alpaka 1.2.0 there is `IsMultiThreadAcc`, but we cannot use this yet). I have also added a static assertion for this.
|
I think in principle you can achieve this more neatly using the IsMultiThreadAcc from here: alpaka-group/alpaka#2263 EDIT: I should have read the description more thoroughly, sorry. Otherwise looks good to me at a glance but Ryan should also comment. |
|
Also looks good to me! |
paulgessinger
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CCL code currently does not support running with a single thread per block; it has to be run with multiple threads per block by design. In order to require this, I have added a new function that asserts this about a device (note that in Alpaka 1.2.0 there is
IsMultiThreadAcc, but we cannot use this yet). I have also added a static assertion for this.