Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Kokkos code compatible with C++20 #649

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

stephenswat
Copy link
Member

The Kokkos code has two problems when it comes to C++20 compatibility. Firstly, the current version simply does not work in C++20 mode; compilation requires Kokkos 4.3.1 or later. There are also some warnings that prevent compilation. This commit fixes these issues by updating to Kokkos 4.3.1 and by adding some hacks to fix the compiler warnings.

@stephenswat stephenswat added bug Something isn't working kokkos Changes related to Kokkos labels Jul 22, 2024
@stephenswat
Copy link
Member Author

@storrealbac @Yhatoh what's the status on the Kokkos code? Do you ever plan on expanding it? Also; can you please let me know if this change is okay for you?

@Yhatoh
Copy link
Contributor

Yhatoh commented Jul 22, 2024

Dear @stephenswat,

First, the change that you propose I agree with them.
The status of the update I think is the same as the last one I presented to you, that is because I had to stop working on, due that I'm doing my PhD and had conflict with my project (and my university has some strict rule with it). Sorry for that, I think I forgot to mention about.

Also, the other student that was working on was @uwo-o, he is Hugo Campos (Sebastian had to leave the project time ago).

And, yet I don't know if Hugo is continuing with my work (should be @uwo-o), in any case you can find my last updates in my fork of Traccc in the branch dev/seeding_algorithm.

Best Regards,
Gabriel Carmona

@stephenswat
Copy link
Member Author

Thanks for the update @Yhatoh

The Kokkos code has two problems when it comes to C++20 compatibility.
Firstly, the current version simply does not work in C++20 mode;
compilation requires Kokkos 4.3.1 or later. There are also some warnings
that prevent compilation. This commit fixes these issues by updating to
Kokkos 4.3.1 and by adding some hacks to fix the compiler warnings.
@stephenswat stephenswat merged commit 800b5e4 into acts-project:main Jul 23, 2024
23 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kokkos Changes related to Kokkos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants