Migrate from setup.py to pyproject.toml
#297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pyproject.toml` is a mainstream (as of today) way to organize Python packages. There are multiple reasons for that, I'll just leave some links: * https://peps.python.org/pep-0517/ * https://peps.python.org/pep-0518/ * https://peps.python.org/pep-0621/ * https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html I've also took liberty to add myself to authors list in metadata, hopefully 21% of commits justifies this. Unfortunately, this stuff doesn't properly work with default pip/setuptools shipped with Python 3.6, so it has to be dropped.
slonopotamus
force-pushed
the
pyproject.toml
branch
from
5f8b57f
to
3724dc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyproject.tomlis a mainstream (as of today) way to organize Python packages.There are multiple reasons for that, I'll just leave some links:
I've also took liberty to add myself to authors list in metadata, hopefully 20% of commits justifies this.
Unfortunately, this stuff doesn't properly work with default pip shipped with Python 3.6, so it has to be dropped. Officially, Python 3.6 became EOL in Dec, 2021.
Implementation details:
pyproject.toml.version.pyloads that using Python metadata machinerysrcdirectory in order to stop setuptools from choking on ourresourcesdir. See https://setuptools.pypa.io/en/latest/userguide/package_discovery.html for details.