Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add all custom categories as valid _type values (fix #120) #121

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix: Add all custom categories as valid _type values (fix #120) #121

merged 1 commit into from
Sep 30, 2024

Conversation

swashbuck
Copy link
Contributor

Fixes #120

Fix

  • Add all custom categories as valid _type values

Testing

  1. Add a resource item with one of the 10 custom types. For example:
{
  "_type": "custom1",
  "title": "Adapt Project Site",
  "description": "View the project's web site by clicking here.",
  "_link": "https://www.adaptlearning.org/"
},
  1. Upload course to the AAT.

@swashbuck swashbuck self-assigned this Sep 17, 2024
@swashbuck swashbuck added the bug label Sep 17, 2024
joe-allen-89
joe-allen-89 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 409f8a0 into master Sep 30, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/120 branch September 30, 2024 14:03
github-actions bot pushed a commit that referenced this pull request Sep 30, 2024
@semantic-release-bot
Chore(release): 5.5.3 [skip ci]
c624fe1 
## [5.5.3](v5.5.2...v5.5.3) (2024-09-30)

### Fix

* Add all custom categories as valid _type values (#121) ([409f8a0](409f8a0)), closes [#121](#121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@swashbuck swashbuck

Labels
bug
Projects
adapt_framework: The TODO Board
Status: Recently Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AAT: Schema does not allow 'custom' types
4 participants
@swashbuck @oliverfoster @cahirodoherty-learningpool @joe-allen-89