Tutor "inline" fails to modify buttons

[chucklorenz]

Subject of the issue/enhancement/features

When Tutor's feedback is set to '"_type": "inline"', Tutor's README is not in sync with its actual behaviour. I don't know which is correct.

My environment

• FW v5.31.17
• Tutor v4.5.8
• MCQ v7.3.11
• Chrome desktop

Steps to reproduce

1. Install Tutor in the demo course installed with the FW.
2. Add the following code to course.json:

"_tutor": {
        "_type": "notify",
        "_classes": "",
        "_hasNotifyBottomButton": false,
        "_button": {
            "text": "{{_globals._extensions._tutor.hideFeedback}}",
            "ariaLabel": "{{_globals._extensions._tutor.hideFeedback}}"
        }
},

3. Add the following code to the first MCQ ("_id": "c-60"):

"_tutor": {
        "_isInherited": false,
        "_type": "inline",
        "_classes": "",
        "_hasNotifyBottomButton": false,
        "_button": {
            "text": "{{_globals._extensions._tutor.hideFeedback}}",
            "ariaLabel": "{{_globals._extensions._tutor.hideFeedback}}"
        }
},

4. Run course and submit a selection of the MCQ--correct or incorrect, doesn't matter.

Expected behaviour

According to the README, I should expect that "inline" will modify the buttons, hiding btn__feedback and adding the is-full-width class to btn__action. I expect this to cause the "Show correct answer" button to become full-width and to cause the "Show feedback" button to disappear.

Actual behaviour

Inline feedback appears below the component, but the buttons remain unmodified as in the following pic. No new classes are added to the buttons.

While the "Show feedback" label is meaningless since the feedback is already displayed, at least the button remains disabled.

I find this actual behaviour regardless of choosing a correct or incorrect option and whether the _tutor config is included or not in course.json.

[github-actions]

🎉 This issue has been resolved in version 4.5.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀