Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(paparazzi): Configure useDeviceResolution to true #1133

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(paparazzi): Configure useDeviceResolution to true #1133

wants to merge 4 commits into from

Conversation

SimonMarquis
Copy link
Member

No description provided.

@SimonMarquis
Copy link
Member Author

@spark-ui-bot paparazzi

@SimonMarquis SimonMarquis force-pushed the paparazzi-useDeviceResolution branch from 891af9f to bbc7fff Compare May 28, 2024 10:17
@github-actions GitHub Actions
Copy link
Contributor

🚨 UI regression detected! Checkout the paparazzi-delta artifact.
If these changes are expected, you can either:

  • manually run the gradlew recordPaparazziRelease and commit the new golden images
  • or ask @spark-ui-bot paparazzi golden images in this PR

@github-actions GitHub Actions
Copy link
Contributor

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: build-test-lint
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android assembleRelease 8.7 ✅ Build Scan not published
spark-android globalCiUnitTest verifyPaparazziRelease 8.7 ❌ Build Scan not published

@SimonMarquis SimonMarquis force-pushed the paparazzi-useDeviceResolution branch from bbc7fff to babcc84 Compare May 28, 2024 11:43
@SimonMarquis
Copy link
Member Author

@spark-ui-bot paparazzi

@github-actions GitHub Actions
Copy link
Contributor

🚨 UI regression detected! Checkout the paparazzi-delta artifact.
If these changes are expected, you can either:

  • manually run the gradlew cleanRecordPaparazziRelease and commit the new golden images
  • or ask @spark-ui-bot paparazzi golden images in this PR

@github-actions GitHub Actions
Copy link
Contributor

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: build-test-lint
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android assembleRelease 8.7 ✅ Build Scan not published
spark-android globalCiUnitTest verifyPaparazziRelease 8.7 ❌ Build Scan not published

@SimonMarquis SimonMarquis force-pushed the paparazzi-useDeviceResolution branch from babcc84 to 4b5711e Compare May 28, 2024 12:53
@SimonMarquis
Copy link
Member Author

@spark-ui-bot paparazzi

@SimonMarquis SimonMarquis marked this pull request as ready for review May 30, 2024 07:26
@SimonMarquis SimonMarquis requested review from soulcramer, kazaky and a team as code owners May 30, 2024 07:26
kazaky
kazaky previously approved these changes Jun 11, 2024
View reviewed changes
@SimonMarquis SimonMarquis force-pushed the paparazzi-useDeviceResolution branch from 074c306 to 6a87e2c Compare June 29, 2024 09:12
@SimonMarquis
Copy link
Member Author

@spark-ui-bot paparazzi

@SimonMarquis
Copy link
Member Author

@soulcramer can you make this change outside this PR?

@soulcramer
Copy link
Contributor

@soulcramer can you make this change outside this PR?

Done, I'll create a separate change on top of it

@soulcramer
Copy link
Contributor

@spark-ui-bot paparazzi

@SimonMarquis SimonMarquis force-pushed the paparazzi-useDeviceResolution branch from 2cc071f to 99f3e55 Compare July 2, 2024 18:43
@SimonMarquis
Copy link
Member Author

@spark-ui-bot paparazzi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazaky kazaky kazaky left review comments

@soulcramer soulcramer Awaiting requested review from soulcramer soulcramer is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@SimonMarquis SimonMarquis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SimonMarquis @soulcramer @kazaky @spark-ui-bot