chore: basic decorateIcons parallel test #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @karlpauls. |
|
I think @davidnuescheler wants to go back to simple icon decorations with adobe/aem-boilerplate#253 and rather move the spriting logic to the block party for now until we have enough stability |
10 tasks
kptdobe
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Thanks @karlpauls for the test case. I have adjusted the test to new implementation.
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic test for adobe/aem-boilerplate#256 - i.e., a styled icon gets loaded in parallel (two promises race to decorateIcons the same icon). With the current boilerplate, this fails pretty reliable - hence, this test should fail (at least most of the time) until it is fixed.